Changeset 0471786 in mainline

Timestamp:

2009-06-16T20:22:58Z (15 years ago)

Author:

Jiri Svoboda <jirik.svoboda@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

62140db

Parents:

08c9f7d

Message:

Fix signedness issues and warnings in fb.

Location:

uspace/srv/fb

Files:

• ega.c (modified) (3 diffs)
• fb.c (modified) (1 diff)

uspace/srv/fb/ega.c

@@ -88 +88 @@
 static void clrscr(void)
 {
-        int i;
+        unsigned i;
         
         for (i = 0; i < scr_width * scr_height; i++) {
@@ -130 +130 @@
 static void scroll(int rows)
 {
-        int i;
+        unsigned i;
+
         if (rows > 0) {
                 memmove(scr_addr, ((char *) scr_addr) + rows * scr_width * 2,
@@ -346 +347 @@
                 case FB_SCROLL:
                         i = IPC_GET_ARG1(call);
-                        if (i > scr_height || i < -((int) scr_height)) {
+                        if (i > (int) scr_height || i < -((int) scr_height)) {
                                 retval = EINVAL;
                                 break;

uspace/srv/fb/fb.c

@@ -451 +451 @@
                 x = vport->x;
                 for (col = 0; col < vport->cols; col++) {
-                        if ((row + lines >= 0) && (row + lines < vport->rows)) {
+                        if (((int) row + lines >= 0) &&
+                            ((int) row + lines < (int) vport->rows)) {
                                 xbp = &vport->backbuf[BB_POS(vport, col, row + lines)];
                                 bbp = &vport->backbuf[BB_POS(vport, col, row)];