Changeset 1519b91 in mainline

Timestamp:

2011-05-06T06:12:56Z (13 years ago)

Author:

Matej Klonfar <maklf@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

b9d7965

Parents:

9d05599

Message:

#209 - correct usage paths for decomposed items

Location:

uspace/lib/usb

Files:

• include/usb/classes/hiddescriptor.h (modified) (1 diff)
• src/hiddescriptor.c (modified) (6 diffs)

uspace/lib/usb/include/usb/classes/hiddescriptor.h

@@ -78 +78 @@
 uint32_t usb_hid_report_tag_data_uint32(const uint8_t *data, size_t size);
 
+void usb_hid_report_path_try_insert(usb_hid_report_t *report, usb_hid_report_path_t *cmp_path);
 #endif
 /**

uspace/lib/usb/src/hiddescriptor.c

@@ -56 +56 @@
 #define USB_HID_UNKNOWN_TAG             -99
 
-
-/**
- * Initialize the report descriptor parser structure
- *
- * @param parser Report descriptor parser structure
- * @return Error code
- */
-int usb_hid_report_init(usb_hid_report_t *report)
-{
-        if(report == NULL) {
-                return EINVAL;
-        }
-
-        memset(report, 0, sizeof(usb_hid_report_t));
-        list_initialize(&report->reports);
-        list_initialize(&report->collection_paths);
-
-        report->use_report_ids = 0;
-    return EOK;   
-}
-
-int usb_hid_report_append_fields(usb_hid_report_t *report, usb_hid_report_item_t *report_item)
-{
-        usb_hid_report_field_t *field;
-        int i;
-
-
+void usb_hid_report_path_try_insert(usb_hid_report_t *report, usb_hid_report_path_t *cmp_path)
+{
         /* find or append current collection path to the list */
         link_t *path_it = report->collection_paths.next;
@@ -89 +64 @@
                 path = list_get_instance(path_it, usb_hid_report_path_t, link);
                 
-                if(usb_hid_report_compare_usage_path(path, report_item->usage_path, USB_HID_PATH_COMPARE_STRICT) == EOK){
+                if(usb_hid_report_compare_usage_path(path, cmp_path, USB_HID_PATH_COMPARE_STRICT) == EOK){
                         break;
                 }                       
@@ -95 +70 @@
         }
         if(path_it == &report->collection_paths) {
-                path = usb_hid_report_path_clone(report_item->usage_path);                      
+                path = usb_hid_report_path_clone(cmp_path);                     
                 list_append(&path->link, &report->collection_paths);                                    
                 report->collection_paths_count++;
         }
+}
+
+/**
+ * Initialize the report descriptor parser structure
+ *
+ * @param parser Report descriptor parser structure
+ * @return Error code
+ */
+int usb_hid_report_init(usb_hid_report_t *report)
+{
+        if(report == NULL) {
+                return EINVAL;
+        }
+
+        memset(report, 0, sizeof(usb_hid_report_t));
+        list_initialize(&report->reports);
+        list_initialize(&report->collection_paths);
+
+        report->use_report_ids = 0;
+    return EOK;   
+}
+
+int usb_hid_report_append_fields(usb_hid_report_t *report, usb_hid_report_item_t *report_item)
+{
+        usb_hid_report_field_t *field;
+        int i;
 
         for(i=0; i<report_item->usages_count; i++){
@@ -104 +105 @@
         }
 
-        
+        usb_hid_report_path_t *path = report_item->usage_path;  
         for(i=0; i<report_item->count; i++){
 
@@ -168 +169 @@
                 }
                 
+                usb_hid_report_set_last_item(path, USB_HID_TAG_CLASS_GLOBAL, field->usage_page);
+                usb_hid_report_set_last_item(path, USB_HID_TAG_CLASS_LOCAL, field->usage);
+
+                usb_hid_report_path_try_insert(report, path);
+
                 field->size = report_item->size;
                 field->offset = report_item->offset + (i * report_item->size);
@@ -349 +355 @@
                                         tmp_usage_path = list_get_instance(report_item->usage_path->link.prev, usb_hid_report_usage_path_t, link);
                                         
-                                        usb_hid_report_set_last_item(usage_path, tmp_usage_path->usage_page, tmp_usage_path->usage);
+                                        usb_hid_report_set_last_item(usage_path, USB_HID_TAG_CLASS_GLOBAL, tmp_usage_path->usage_page);
+                                        usb_hid_report_set_last_item(usage_path, USB_HID_TAG_CLASS_LOCAL, tmp_usage_path->usage);
 
                                         usb_hid_report_path_free(report_item->usage_path);