Changeset 33e15a0 in mainline

Timestamp:

2024-01-21T15:36:03Z (3 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

11909ce3

Parents:

7364e2d1

Message:

Make thread→btrace weakly atomic, to avoid need for thread lock

Location:

kernel/generic

Files:

• include/proc/thread.h (modified) (1 diff)
• src/proc/scheduler.c (modified) (2 diffs)
• src/proc/thread.c (modified) (2 diffs)

kernel/generic/include/proc/thread.h

@@ -170 +170 @@
          * to the kernel console upon scheduling this thread.
          */
-        bool btrace;
+        atomic_int_fast8_t btrace;
 
         /** Debugging stuff */

kernel/generic/src/proc/scheduler.c

@@ -340 +340 @@
 
 #ifdef CONFIG_UDEBUG
-        if (THREAD->btrace) {
+        if (atomic_get_unordered(&THREAD->btrace)) {
                 istate_t *istate = THREAD->udebug.uspace_state;
                 if (istate != NULL) {
@@ -349 +349 @@
                 }
 
-                THREAD->btrace = false;
+                atomic_set_unordered(&THREAD->btrace, false);
         }
 #endif

kernel/generic/src/proc/thread.c

@@ -289 +289 @@
 #ifdef CONFIG_UDEBUG
         /* Initialize debugging stuff */
-        thread->btrace = false;
+        atomic_init(&thread->btrace, false);
         udebug_thread_initialize(&thread->udebug);
 #endif
@@ -908 +908 @@
 
         printf("Scheduling thread stack trace.\n");
-        irq_spinlock_lock(&thread->lock, true);
-        thread->btrace = true;
-        irq_spinlock_unlock(&thread->lock, true);
+        atomic_set_unordered(&thread->btrace, true);
 
         thread_wakeup(thread);