Changeset 53af6e8c in mainline

Timestamp:

2012-08-26T13:53:26Z (12 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

eb5560a

Parents:

20282ef3

Message:

No need to hold the sender task when the call is going to be answered.
The sender may no longer forget the call and, in fact, must wait for it.

Location:

kernel/generic/src/ipc

Files:

• ipc.c (modified) (2 diffs)
• sysipc.c (modified) (3 diffs)

kernel/generic/src/ipc/ipc.c

@@ -196 +196 @@
         } else {
                 /*
-                 * Hold the sender task so that it does not suddenly disappear
-                 * while we are working with it.
-                 */
-                task_hold(call->sender);
-
-                /*
                  * If the call is still active, i.e. it was answered
                  * in a non-standard way, remove the call from the
@@ -232 +226 @@
         
         waitq_wakeup(&callerbox->wq, WAKEUP_FIRST);
-
-        task_release(call->sender);
 }
 

kernel/generic/src/ipc/sysipc.c

@@ -194 +194 @@
                 list_remove(&answer->ta_link);
                 spinlock_unlock(&answer->sender->active_calls_lock);
-
-                /*
-                 * Hold the sender task so that it cannot suddenly disappear
-                 * while we are working with it.
-                 */
-                task_hold(answer->sender);
         }
         spinlock_unlock(&answer->forget_lock);
@@ -217 +211 @@
         }
         
-        if (!olddata) {
-                task_release(answer->sender);
+        if (!olddata)
                 return rc;
-        }
-        
 
         ops = sysipc_ops_get(answer->request_method);
@@ -227 +218 @@
                 rc = ops->answer_preprocess(answer, olddata);
         
-        task_release(answer->sender);
-
         return rc;
 }