Changeset 705f83a in mainline

Timestamp:

2018-01-29T16:05:44Z (6 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

8bfb163

Parents:

ee0ffa6

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-29 16:04:43)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-29 16:05:44)

Message:

ohci: fix the batch preparation time again

Due to the stupid design decision of leaving one TD behind a transfer,
the batch preparation needs to be done with EP locked.

File:

• uspace/drv/bus/usb/ohci/hc.c (modified) (2 diffs)

uspace/drv/bus/usb/ohci/hc.c

@@ -301 +301 @@
         ohci_endpoint_t * const ohci_ep = ohci_endpoint_get(ep);
         ohci_transfer_batch_t *ohci_batch = ohci_transfer_batch_get(batch);
-
         int err;
-        if ((err = ohci_transfer_batch_prepare(ohci_batch)))
-                return err;
 
         fibril_mutex_lock(&hc->guard);
@@ -311 +308 @@
                 return err;
         }
+
+        if ((err = ohci_transfer_batch_prepare(ohci_batch)))
+                return err;
 
         ohci_transfer_batch_commit(ohci_batch);