Changeset 72786f38 in mainline

Timestamp:

2019-07-02T14:00:28Z (5 years ago)

Author:

Jaroslav Jindrak <dzejrou@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

5ab9df4

Parents:

d3ba97d

Message:

cpp: moved all the at_exit logic to two functions which are to be implemented later to avoid TODO duplication throughout the code

Location:

uspace/lib/cpp/include/__bits/thread

Files:

• packaged_task.hpp (modified) (1 diff)
• promise.hpp (modified) (4 diffs)
• shared_state.hpp (modified) (1 diff)

uspace/lib/cpp/include/__bits/thread/packaged_task.hpp

@@ -179 +179 @@
             void make_ready_at_thread_exit(Args...)
             {
-                // TODO: implement
+                if (!state_)
+                    throw future_error{make_error_code(future_errc::no_state)};
+                if (state_->is_set())
+                {
+                    throw future_error{
+                        make_error_code(future_errc::promise_already_satisfied)
+                    };
+                }
+
+                try
+                {
+                    state_->set_value(invoke(func_, args...), false);
+                }
+                catch(const exception& __exception)
+                {
+                    state_->set_exception(make_exception_ptr(__exception), false);
+                }
+
+                aux::set_state_value_at_thread_exit(state_);
             }
 

uspace/lib/cpp/include/__bits/thread/promise.hpp

@@ -106 +106 @@
 
                     state_->set_exception_ptr(ptr, false);
-                    // TODO: Mark it as 'has_exception' when thread terminates.
+                    aux::set_state_exception_at_thread_exit(state_);
                 }
 
@@ -226 +226 @@
 
                 this->state_->set_value(val, false);
-                // TODO: schedule it to be set as ready when thread exits
+                aux::set_state_value_at_thread_exit(state_);
             }
 
@@ -241 +241 @@
 
                 this->state_->set_value(forward<R>(val), false);
-                // TODO: schedule it to be set as ready when thread exits
+                aux::set_state_value_at_thread_exit(state_);
             }
     };
@@ -312 +312 @@
 
                 this->state_->set_value(&val, false);
-                // TODO: schedule it to be set as ready when thread exits
+                aux::set_state_value_at_thread_exit(state_);
             }
     };

uspace/lib/cpp/include/__bits/thread/shared_state.hpp

@@ -371 +371 @@
             }
     };
+
+    /**
+     * Note: The following two functions should:
+     *   1) Increment refcount.
+     *   2) Store ptr to a vector of shared_state_base ptrs
+     *      (as those have ::mark_set member functions).
+     *   3) If not done already, register a function
+     *      executing all these in the thread_atexit function
+     *      once that is implemented.
+     */
+
+    template<class R>
+    void set_state_value_at_thread_exit(shared_state<R>* state)
+    {
+        // TODO: implement
+    }
+
+    template<class R>
+    void set_state_exception_at_thread_exit(shared_state<R>* state)
+    {
+        // TODO: implement
+    }
 }