Changeset 7852625 in mainline

Timestamp:

2012-01-05T17:49:20Z (12 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0a549cc

Parents:

9f0fb84

Message:

zone_external_conf_alloc() must be allowed to fail gracefully (by passing FRAME_ATOMIC to frame_alloc()), otherwise the frame_alloc_generic() might panic on the "Cannot wait for memory to become available" assertion in specific memory configurations

Location:

kernel

Files:

• arch/arm32/src/mm/frame.c (modified) (1 diff)
• arch/ia32/src/mm/frame.c (modified) (1 diff)
• arch/ia64/src/mm/frame.c (modified) (1 diff)
• arch/mips32/src/mm/frame.c (modified) (1 diff)
• arch/mips64/src/mm/frame.c (modified) (1 diff)
• arch/ppc32/src/mm/frame.c (modified) (1 diff)
• arch/sparc64/src/mm/sun4u/frame.c (modified) (1 diff)
• arch/sparc64/src/mm/sun4v/frame.c (modified) (1 diff)
• generic/src/mm/frame.c (modified) (1 diff)

kernel/arch/arm32/src/mm/frame.c

@@ -60 +60 @@
         } else {
                 pfn_t conf = zone_external_conf_alloc(SIZE2FRAMES(size));
-
-                zone_create(ADDR2PFN(base), SIZE2FRAMES(size), conf,
-                    ZONE_AVAILABLE | ZONE_HIGHMEM);
+                if (conf != 0)
+                        zone_create(ADDR2PFN(base), SIZE2FRAMES(size), conf,
+                            ZONE_AVAILABLE | ZONE_HIGHMEM);
         }
         

kernel/arch/ia32/src/mm/frame.c

@@ -79 +79 @@
                         } else {
                                 conf = zone_external_conf_alloc(count);
-                                zone_create(pfn, count, conf,
-                                    ZONE_AVAILABLE | ZONE_HIGHMEM);
+                                if (conf != 0)
+                                        zone_create(pfn, count, conf,
+                                            ZONE_AVAILABLE | ZONE_HIGHMEM);
                         }
                 } else if ((e820table[i].type == MEMMAP_MEMORY_ACPI) ||

kernel/arch/ia64/src/mm/frame.c

@@ -79 +79 @@
                                     ZONE_AVAILABLE | ZONE_LOWMEM);
                         } else {
-                                pfn_t conf;
-
-                                conf = zone_external_conf_alloc(count);
-                                zone_create(pfn, count, conf,
-                                    ZONE_AVAILABLE | ZONE_HIGHMEM);
+                                pfn_t conf = zone_external_conf_alloc(count);
+                                if (conf != 0)
+                                        zone_create(pfn, count, conf,
+                                            ZONE_AVAILABLE | ZONE_HIGHMEM);
                         }
                 }

kernel/arch/mips32/src/mm/frame.c

@@ -156 +156 @@
         } else {
                 conf_frame = zone_external_conf_alloc(count);
-                zone_create(first, count, conf_frame,
-                    ZONE_AVAILABLE | ZONE_HIGHMEM);
-        }
-                
-                
+                if (conf_frame != 0)
+                        zone_create(first, count, conf_frame,
+                            ZONE_AVAILABLE | ZONE_HIGHMEM);
+        }
+        
         if (phys_regions_count < MAX_REGIONS) {
                 phys_regions[phys_regions_count].start = first;

kernel/arch/mips64/src/mm/frame.c

@@ -148 +148 @@
         } else {
                 conf_frame = zone_external_conf_alloc(count);
-                zone_create(first, count, conf_frame,
-                    ZONE_AVAILABLE | ZONE_HIGHMEM);
-        }
-                
-                
+                if (conf_frame != 0)
+                        zone_create(first, count, conf_frame,
+                            ZONE_AVAILABLE | ZONE_HIGHMEM);
+        }
+        
         if (phys_regions_count < MAX_REGIONS) {
                 phys_regions[phys_regions_count].start = first;

kernel/arch/ppc32/src/mm/frame.c

@@ -81 +81 @@
                 } else {
                         conf = zone_external_conf_alloc(count);
-                        zone_create(pfn, count, conf,
-                            ZONE_AVAILABLE | ZONE_HIGHMEM);
+                        if (conf != 0)
+                                zone_create(pfn, count, conf,
+                                    ZONE_AVAILABLE | ZONE_HIGHMEM);
                 }
         }

kernel/arch/sparc64/src/mm/sun4u/frame.c

@@ -79 +79 @@
                 } else {
                         confdata = zone_external_conf_alloc(count);
-                        zone_create(pfn, count, confdata,
-                            ZONE_AVAILABLE | ZONE_HIGHMEM);
+                        if (confdata != 0)
+                                zone_create(pfn, count, confdata,
+                                    ZONE_AVAILABLE | ZONE_HIGHMEM);
                 }
         }
-                
 }
 

kernel/arch/sparc64/src/mm/sun4v/frame.c

@@ -79 +79 @@
                 } else {
                         confdata = zone_external_conf_alloc(count);
-                        zone_create(pfn, count, confdata,
-                            ZONE_AVAILABLE | ZONE_HIGHMEM);
+                        if (confdata != 0)
+                                zone_create(pfn, count, confdata,
+                                    ZONE_AVAILABLE | ZONE_HIGHMEM);
                 }
         }
-                
 }
 

kernel/generic/src/mm/frame.c

@@ -870 +870 @@
         size_t order = ispwr2(size) ? fnzb(size) : (fnzb(size) + 1);
 
-        return ADDR2PFN((uintptr_t) frame_alloc(order - FRAME_WIDTH, FRAME_LOWMEM));
+        return ADDR2PFN((uintptr_t) frame_alloc(order - FRAME_WIDTH,
+            FRAME_LOWMEM | FRAME_ATOMIC));
 }