Changeset 84e74ea in mainline

Timestamp:

2020-06-08T18:30:52Z (4 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

bc492d5

Parents:

a65b0c8

Message:

Remove XXX comment from each call to display_get_gc()

These were added with the intent that each piece of code that does rendering
in the display server is augmented with a loop over all display devices.
The better solution seems to be to introduce a virtualization layer in the
form of a cloning GC that clones the rendering operations to each display
device. It makes the business code simpler and separates concerns better.
It could also allow having more types of output GCs, than just display
devices (such as an 'observer' for RFB).

Location:

uspace/srv/hid/display

Files:

• cursor.c (modified) (1 diff)
• display.c (modified) (3 diffs)
• window.c (modified) (3 diffs)

uspace/srv/hid/display/cursor.c

@@ -103 +103 @@
         errno_t rc;
 
-        dgc = ds_display_get_gc(cursor->display); // XXX
+        dgc = ds_display_get_gc(cursor->display);
         if (dgc == NULL)
                 return EOK;

uspace/srv/hid/display/display.c

@@ -585 +585 @@
 }
 
-// XXX
+/** Get unbuffered GC.
+ *
+ * Get the display's (unbuffered) graphic context. If the display
+ * is double-buffered, this returns GC of the front buffer. If the display
+ * is unbuffered, this is the same as @c ds_display_get_gc().
+ *
+ * @param display Display
+ * @return Unbuffered GC
+ */
 static gfx_context_t *ds_display_get_unbuf_gc(ds_display_t *display)
 {
         ds_ddev_t *ddev;
 
+        /*
+         * XXX To properly support multiple display devices, create
+         * a cloning GC that copies rendering operation to each output.
+         */
         ddev = ds_display_first_ddev(display);
         if (ddev == NULL)
@@ -597 +609 @@
 }
 
-// XXX
+/** Get display GC.
+ *
+ * Get the graphic context used to paint the display. This is to be used
+ * for all display server paint operations.
+ *
+ * @param display Display
+ * @return Graphic context for painting to the display
+ */
 gfx_context_t *ds_display_get_gc(ds_display_t *display)
 {
@@ -622 +641 @@
                 crect = disp->rect;
 
-        gc = ds_display_get_gc(disp); // XXX
+        gc = ds_display_get_gc(disp);
         if (gc == NULL)
                 return EOK;

uspace/srv/hid/display/window.c

@@ -84 +84 @@
         bparams.rect = params->rect;
 
-        dgc = ds_display_get_gc(wnd->display); // XXX
+        dgc = ds_display_get_gc(wnd->display);
         if (dgc != NULL) {
                 rc = gfx_bitmap_create(dgc, &bparams, NULL, &wnd->bitmap);
@@ -268 +268 @@
                 return rc;
 
-        gc = ds_display_get_gc(wnd->display); // XXX
+        gc = ds_display_get_gc(wnd->display);
         if (gc != NULL) {
                 gfx_set_color(gc, color);
@@ -695 +695 @@
         errno_t rc;
 
-        dgc = ds_display_get_gc(wnd->display); // XXX
+        dgc = ds_display_get_gc(wnd->display);
         if (dgc != NULL) {
                 gfx_bitmap_params_init(&bparams);