Changeset 887c9de in mainline

Timestamp:

2017-11-09T12:19:52Z (7 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f9d0a86

Parents:

41df71f9

Message:

xhci: added missing write barrier

Location:

uspace/drv/bus/usb/xhci

Files:

• hw_struct/trb.h (modified) (3 diffs)
• trb_ring.c (modified) (1 diff)

uspace/drv/bus/usb/xhci/hw_struct/trb.h

@@ -40 +40 @@
 
 #include "common.h"
+#include <libarch/barrier.h>
 
 /**
@@ -169 +170 @@
 }
 
-static inline void xhci_trb_copy(xhci_trb_t *dst, xhci_trb_t *src)
+static inline void xhci_trb_copy_to_pio(xhci_trb_t *dst, xhci_trb_t *src)
 {
         /*
@@ -177 +178 @@
         dst->parameter = src->parameter;
         dst->status = src->status;
+
+        write_barrier();
+
         dst->control = src->control;
 }

uspace/drv/bus/usb/xhci/trb_ring.c

@@ -218 +218 @@
         for (size_t i = 0; i < trbs; ++i, ++trb) {
                 TRB_SET_CYCLE(*trb, ring->pcs);
-                xhci_trb_copy(ring->enqueue_trb, trb);
+                xhci_trb_copy_to_pio(ring->enqueue_trb, trb);
 
                 usb_log_debug2("TRB ring(%p): Enqueued TRB %p", ring, trb);