Changeset b2acdf32 in mainline

Timestamp:

2018-08-29T20:05:52Z (6 years ago)

Author:

Jiří Zárevúcky <jiri.zarevucky@…>

Children:

184ff675

Parents:

b1b201f

git-author:

Jiří Zárevúcky <jiri.zarevucky@…> (2018-08-29 15:48:16)

git-committer:

Jiří Zárevúcky <jiri.zarevucky@…> (2018-08-29 20:05:52)

Message:

Remove unused and not well tested atan()/atan2()

Location:

uspace

Files:

• app/tester/float/float2.c (modified) (3 diffs)
• lib/math/Makefile (modified) (1 diff)
• lib/math/generic/atan.c (deleted)
• lib/math/generic/atan2.c (deleted)
• lib/math/include/atan.h (deleted)
• lib/math/include/atan2.h (deleted)
• lib/math/include/math.h (modified) (3 diffs)

uspace/app/tester/float/float2.c

@@ -43 +43 @@
 };
 
-static double arguments_atan[OPERANDS] = {
-        3.5, 100.0, 50.0, 768.3156, 1080.499999, 1.0, 66.0,
-        2.718281828459045, 9.9, 0.001
-};
-
 static double arguments_exp[OPERANDS] = {
         3.5, -2.1, 50.0, 0.0, 1.0, 13.2, -1.1, -5.5, 0.1, -66.0
@@ -64 +59 @@
 static double arguments_tanh[OPERANDS] = {
         3.5, -2.1, 50.0, 0.0, 1.0, 13.2, -1.1, -5.5, 0.000001, -66000000.0
-};
-
-static double results_atan[OPERANDS] = {
-        1.292496667790, 1.560796660108, 1.550798992822, 1.569494779052,
-        1.569870829603, 0.785398163397, 1.555645970920, 1.218282905017,
-        1.470127674637, 0.000999999667
 };
 
@@ -193 +182 @@
 
         for (unsigned int i = 0; i < OPERANDS; i++) {
-                double res = atan(arguments_atan[i]);
-
-                if (!cmp_double(res, results_atan[i])) {
-                        TPRINTF("Double precision atan failed "
-                            "(%.12lf != %.12lf, arg %u)\n", res, results_atan[i], i);
-                        fail = true;
-                }
-        }
-
-        for (unsigned int i = 0; i < OPERANDS; i++) {
-                float res = atanf(arguments_atan[i]);
-
-                if (!cmp_float(res, results_atan[i])) {
-                        TPRINTF("Single precision atan failed "
-                            "(%f != %lf, arg %u)\n", res, results_atan[i], i);
-                        fail = true;
-                }
-        }
-
-        for (unsigned int i = 0; i < OPERANDS; i++) {
                 double res = ceil(arguments[i]);
 

uspace/lib/math/Makefile

@@ -34 +34 @@
 
 SOURCES = \
-        generic/atan.c \
-        generic/atan2.c \
         generic/ceil.c \
         generic/cosh.c \

uspace/lib/math/include/math.h

@@ -37 +37 @@
 #define LIBMATH_MATH_H_
 
-#include <atan.h>
-#include <atan2.h>
 #include <ceil.h>
 #include <cosh.h>
@@ -62 +60 @@
 #define HUGE_VAL FLOAT64_INF
 
-static inline float64_t atan_f64(float64_t val)
-{
-        return float64_atan(val);
-}
-
-static inline float32_t atan_f32(float32_t val)
-{
-        return float32_atan(val);
-}
-
-static inline float64_t atan2_f64(float64_t y, float64_t x)
-{
-        return float64_atan2(y, x);
-}
-
-static inline float32_t atan2_f32(float32_t y, float32_t x)
-{
-        return float32_atan2(y, x);
-}
-
 static inline float64_t ceil_f64(float64_t val)
 {
@@ -279 +257 @@
 {
         return float32_trunc(val);
-}
-
-static inline float64_t atan(float64_t val)
-{
-        return atan_f64(val);
-}
-
-static inline float32_t atanf(float32_t val)
-{
-        return atan_f32(val);
-}
-
-static inline float64_t atan2(float64_t y, float64_t x)
-{
-        return atan2_f64(y, x);
-}
-
-static inline float32_t atan2f(float32_t y, float32_t x)
-{
-        return atan2_f32(y, x);
 }