Changeset dc75234 in mainline

Timestamp:

2011-03-03T21:30:59Z (13 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

bdc8ab1

Parents:

0e2fdcf

Message:

Remove possible endless cycle

File:

• uspace/drv/pciintel/pci.c (modified) (3 diffs)

uspace/drv/pciintel/pci.c

@@ -94 +94 @@
   sysarg_t apic;
   sysarg_t i8259;
+
         int irc_phone = -1;
         int irc_service = 0;
@@ -103 +104 @@
         }
 
-  if (irc_service) {
-    while (irc_phone < 0)
-      irc_phone = service_connect_blocking(irc_service, 0, 0);
-  } else {
+  if (irc_service == 0)
                 return false;
-        }
+
+        irc_phone = service_connect_blocking(irc_service, 0, 0);
+        if (irc_phone < 0)
+                return false;
 
         size_t i;
@@ -114 +115 @@
                 if (dev_data->hw_resources.resources[i].type == INTERRUPT) {
                         int irq = dev_data->hw_resources.resources[i].res.interrupt.irq;
-                        async_msg_1(irc_phone, IRC_ENABLE_INTERRUPT, irq);
+                        int rc = async_req_1_0(irc_phone, IRC_ENABLE_INTERRUPT, irq);
+                        if (rc != EOK) {
+                                async_hangup(irc_phone);
+                                return false;
+                        }
                 }
         }