Changeset 1569a9b in mainline for uspace/lib/c/include/io/klog.h

Timestamp:

2017-12-24T16:40:33Z (6 years ago)

Author:

GitHub <noreply@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

48fd597

Parents:

a1026da

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2017-12-24 16:40:33)

git-committer:

GitHub <noreply@…> (2017-12-24 16:40:33)

Message:

The "not-so-obvious" error handling tweaks. (#9)

Some more changes to enable type-checking with errno_t. Some of the "fixes" here don't quite feel right, but a proper solution would be a more elaborate refactoring of the surrounding code.

File:

• uspace/lib/c/include/io/klog.h (modified) (1 diff)

uspace/lib/c/include/io/klog.h

@@ -49 +49 @@
 #define KLOG_PRINTF(lvl, fmt, ...) ({ \
         char *_s; \
-        int _c = asprintf(&_s, fmt, ##__VA_ARGS__); \
-        if (_c >= 0) { \
-                _c = klog_write((lvl), _s, str_size(_s)); \
+        int _rc = ENOMEM; \
+        if (asprintf(&_s, fmt, ##__VA_ARGS__) >= 0) { \
+                _rc = klog_write((lvl), _s, str_size(_s)); \
                 free(_s); \
         }; \
-        (_c >= 0); \
+        (_rc != EOK); \
 })