Changeset 197ef43 in mainline for uspace/lib/c/generic/libc.c

Timestamp:

2011-01-29T23:52:07Z (13 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

12573db, 40fb017

Parents:

6aef742 (diff), 47b7006 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

merge various cosmetic run-time support improvements

• coding style cleanups, comments cleanups, unsigned types for bit flags, indentation, etc.
• SYS_TASK_EXIT for proper termination of a task (optionally with udebug notification)
  • get rid of exit(), _exit(), core()
  • reimplement robust main(), exit() and abort()
  • call abort() if some part of libc initialization fails
• add more private libc headers to reduce the namespace pollution

File:

• uspace/lib/c/generic/libc.c (modified) (3 diffs)

uspace/lib/c/generic/libc.c

@@ -41 +41 @@
  */
 
-#include <stdio.h>
-#include <unistd.h>
-#include <malloc.h>
+#include <libc.h>
+#include <stdlib.h>
 #include <tls.h>
-#include <thread.h>
 #include <fibril.h>
-#include <async.h>
-#include <as.h>
+#include <task.h>
 #include <loader/pcb.h>
 #include "private/libc.h"
+#include "private/async.h"
+#include "private/async_sess.h"
+#include "private/malloc.h"
+#include "private/io.h"
 
-void _exit(int status)
-{
-        thread_exit(status);
-}
+static bool env_setup = false;
 
 void __main(void *pcb_ptr)
 {
         /* Initialize user task run-time environment */
-        __heap_init();
+        __malloc_init();
         __async_init();
+        __async_sess_init();
+        
         fibril_t *fibril = fibril_setup();
+        if (fibril == NULL)
+                abort();
+        
         __tcb_set(fibril->tcb);
         
@@ -68 +71 @@
         __pcb = (pcb_t *) pcb_ptr;
         
+        /* The basic run-time environment is setup */
+        env_setup = true;
+        
         int argc;
         char **argv;
         
-        /* Get command line arguments and initialize
-           standard input and output */
+        /*
+         * Get command line arguments and initialize
+         * standard input and output
+         */
         if (__pcb == NULL) {
                 argc = 0;
@@ -84 +92 @@
         }
         
-        /* Run main() and set task return value
-           according the result */
-        (void) task_retval(main(argc, argv));
+        /*
+         * Run main() and set task return value
+         * according the result
+         */
+        int retval = main(argc, argv);
+        exit(retval);
 }
 
-void __exit(void)
+void exit(int status)
 {
-        __stdio_done();
-        fibril_teardown(__tcb_get()->fibril_data);
-        _exit(0);
+        if (env_setup) {
+                __stdio_done();
+                task_retval(status);
+                fibril_teardown(__tcb_get()->fibril_data);
+        }
+        
+        __SYSCALL1(SYS_TASK_EXIT, false);
+        
+        /* Unreachable */
+        while (1);
+}
+
+void abort(void)
+{
+        __SYSCALL1(SYS_TASK_EXIT, true);
+        
+        /* Unreachable */
+        while (1);
 }