Changeset 4f87a85a in mainline for uspace/drv/block/ata_bd/main.c

Timestamp:

2018-12-10T14:29:35Z (5 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

ca4c5596

Parents:

433d52f

git-author:

Jiri Svoboda <jiri@…> (2018-12-10 07:39:07)

git-committer:

Jiri Svoboda <jiri@…> (2018-12-10 14:29:35)

Message:

Check return code from ddf_add_fun_to_category

File:

• uspace/drv/block/ata_bd/main.c (modified) (3 diffs)

uspace/drv/block/ata_bd/main.c

@@ -162 +162 @@
         ddf_fun_t *fun = NULL;
         ata_fun_t *afun = NULL;
+        bool bound = false;
 
         fun_name = ata_fun_name(disk);
@@ -202 +203 @@
         }
 
-        ddf_fun_add_to_category(fun, "disk");
+        bound = true;
+
+        rc = ddf_fun_add_to_category(fun, "disk");
+        if (rc != EOK) {
+                ddf_msg(LVL_ERROR, "Failed adding function %s to "
+                    "category 'disk': %s", fun_name, str_error(rc));
+                goto error;
+        }
 
         free(fun_name);
@@ -208 +216 @@
         return EOK;
 error:
+        if (bound)
+                ddf_fun_unbind(fun);
         if (fun != NULL)
                 ddf_fun_destroy(fun);