Changeset 516e780 in mainline for uspace/lib/math/generic/trig.c

Timestamp:

2018-08-31T11:55:41Z (6 years ago)

Author:

GitHub <noreply@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fa86fff

Parents:

7f7d642

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-08-31 11:55:41)

git-committer:

GitHub <noreply@…> (2018-08-31 11:55:41)

Message:

Strip down libmath. (#45)

libmath is mostly unused (except for trunc(), sin() and cos()), and most functions in it are either very imprecise or downright broken. Additionally, it is implemented in manner that conflicts with C standard. Instead of trying to fix all the shortcomings while maintaining unused functionality, I'm opting to simply remove most of it and only keep the parts that are currently necessary.

Later readdition of the removed functions is possible, but there needs to be a reliable way to evaluate their quality first.

File:

• uspace/lib/math/generic/trig.c (modified) (14 diffs)

uspace/lib/math/generic/trig.c

@@ -35 +35 @@
 
 #include <math.h>
-#include <trig.h>
 
 #define TAYLOR_DEGREE_32 13
@@ -41 +40 @@
 
 /** Precomputed values for factorial (starting from 1!) */
-static float64_t factorials[TAYLOR_DEGREE_64] = {
+static double factorials[TAYLOR_DEGREE_64] = {
         1, 2, 6, 24, 120, 720, 5040, 40320, 362880, 3628800, 39916800,
         479001600, 6227020800.0L, 87178291200.0L, 1307674368000.0L,
@@ -60 +59 @@
  *
  */
-static float32_t taylor_sin_32(float32_t arg)
-{
-        float32_t ret = 0;
-        float32_t nom = 1;
+static float taylor_sin_32(float arg)
+{
+        float ret = 0;
+        float nom = 1;
 
         for (unsigned int i = 0; i < TAYLOR_DEGREE_32; i++) {
@@ -89 +88 @@
  *
  */
-static float64_t taylor_sin_64(float64_t arg)
-{
-        float64_t ret = 0;
-        float64_t nom = 1;
+static double taylor_sin_64(double arg)
+{
+        double ret = 0;
+        double nom = 1;
 
         for (unsigned int i = 0; i < TAYLOR_DEGREE_64; i++) {
@@ -118 +117 @@
  *
  */
-static float32_t taylor_cos_32(float32_t arg)
-{
-        float32_t ret = 1;
-        float32_t nom = 1;
+static float taylor_cos_32(float arg)
+{
+        float ret = 1;
+        float nom = 1;
 
         for (unsigned int i = 0; i < TAYLOR_DEGREE_32; i++) {
@@ -147 +146 @@
  *
  */
-static float64_t taylor_cos_64(float64_t arg)
-{
-        float64_t ret = 1;
-        float64_t nom = 1;
+static double taylor_cos_64(double arg)
+{
+        double ret = 1;
+        double nom = 1;
 
         for (unsigned int i = 0; i < TAYLOR_DEGREE_64; i++) {
@@ -176 +175 @@
  *
  */
-static float32_t base_sin_32(float32_t arg)
+static float base_sin_32(float arg)
 {
         unsigned int period = arg / (M_PI / 4);
@@ -209 +208 @@
  *
  */
-static float64_t base_sin_64(float64_t arg)
+static double base_sin_64(double arg)
 {
         unsigned int period = arg / (M_PI / 4);
@@ -242 +241 @@
  *
  */
-static float32_t base_cos_32(float32_t arg)
+static float base_cos_32(float arg)
 {
         unsigned int period = arg / (M_PI / 4);
@@ -275 +274 @@
  *
  */
-static float64_t base_cos_64(float64_t arg)
+static double base_cos_64(double arg)
 {
         unsigned int period = arg / (M_PI / 4);
@@ -305 +304 @@
  *
  */
-float32_t float32_sin(float32_t arg)
-{
-        float32_t base_arg = fmod_f32(arg, 2 * M_PI);
+float sinf(float arg)
+{
+        float base_arg = fmodf(arg, 2 * M_PI);
 
         if (base_arg < 0)
@@ -324 +323 @@
  *
  */
-float64_t float64_sin(float64_t arg)
-{
-        float64_t base_arg = fmod_f64(arg, 2 * M_PI);
+double sin(double arg)
+{
+        double base_arg = fmod(arg, 2 * M_PI);
 
         if (base_arg < 0)
@@ -343 +342 @@
  *
  */
-float32_t float32_cos(float32_t arg)
-{
-        float32_t base_arg = fmod_f32(arg, 2 * M_PI);
+float cosf(float arg)
+{
+        float base_arg = fmodf(arg, 2 * M_PI);
 
         if (base_arg < 0)
@@ -362 +361 @@
  *
  */
-float64_t float64_cos(float64_t arg)
-{
-        float64_t base_arg = fmod_f64(arg, 2 * M_PI);
+double cos(double arg)
+{
+        double base_arg = fmod(arg, 2 * M_PI);
 
         if (base_arg < 0)