Changeset 587867a in mainline for uspace/app/bdsh/compl.c

Timestamp:

2019-03-16T13:01:30Z (5 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

aeeaf0f

Parents:

1c481ee

Message:

improve error handling

The code did not test if malloc returned NULL.
This meant that the code potentially could break without
that the user was informed.

File:

• uspace/app/bdsh/compl.c (modified) (2 diffs)

uspace/app/bdsh/compl.c

@@ -219 +219 @@
                 if (!is_path(prefix) && cs->is_command) {
                         cs->path_list[0] = malloc(sizeof(char) * PATH_MAX);
+                        if (cs->path_list[0] == NULL) {
+                                retval = ENOMEM;
+                                goto error;
+                        }
+
                         int ret = snprintf(cs->path_list[0], PATH_MAX, "%s/%s", search_dir[0], dirname);
                         if (ret < 0 || ret >= PATH_MAX) {
@@ -228 +233 @@
                 }
 
+                free(prefix);
                 cs->path_list[1] = NULL;
                 /*