Changeset 6eef3c4 in mainline for kernel/generic/src/udebug/udebug_ops.c

Timestamp:

2012-06-20T16:18:37Z (12 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

8b36bf2, f22dc820

Parents:

abfc9f3

Message:

cleanup thread_create() and thread_t structure

• remove 'flag' bitfield from thread_t, use individual boolean flags (can be optimized later on by adding : 1)
• use an enum for call flags, add THREAD_FLAG_NONE
• remove the 'uncounted' argument in favour of a call flag
• introduce thread_wire() to setup wired threads

File:

• kernel/generic/src/udebug/udebug_ops.c (modified) (3 diffs)

kernel/generic/src/udebug/udebug_ops.c

@@ -95 +95 @@
         
         /* Verify that 'thread' is a userspace thread. */
-        if ((thread->flags & THREAD_FLAG_USPACE) == 0) {
+        if (!thread->uspace) {
                 /* It's not, deny its existence */
                 irq_spinlock_unlock(&thread->lock, true);
@@ -200 +200 @@
                 
                 mutex_lock(&thread->udebug.lock);
-                if ((thread->flags & THREAD_FLAG_USPACE) != 0) {
+                if (thread->uspace) {
                         thread->udebug.active = true;
                         mutex_unlock(&thread->udebug.lock);
@@ -393 +393 @@
                 
                 irq_spinlock_lock(&thread->lock, false);
-                int flags = thread->flags;
+                bool uspace = thread->uspace;
                 irq_spinlock_unlock(&thread->lock, false);
                 
                 /* Not interested in kernel threads. */
-                if ((flags & THREAD_FLAG_USPACE) == 0)
+                if (!uspace)
                         continue;