Changeset 7e1b130 in mainline for uspace/drv/bus/usb/ohci/ohci.c

Timestamp:

2011-12-23T18:13:33Z (12 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

3819ce5, b39eb79, f0b74b2

Parents:

2f0dd2a (diff), 153cc76a (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

USB branch changes.

+ USB device drivers use single async session to host controller, this session (represented by usb_hc_connection_t) is used for both HC requests and to back usb device connection.
+ Pipe locking was removed. Reference counting was moved to usb_hc_connection_t. Every read/write operation uses separate parallel exchange thus any contention is resolved on hc side.

• async_sess_t setup using EXCHANGE_PARALLEL uses one extra phone (session phone, each exch creates its own), thus the number of phones used by usb dvice driver might increase. Possible solutions are: make read/write calls atomic (all other calls are atomic) and use EXCHANGE_ATOMIC, any other solution provided by changes to async_sess_t.

File:

• uspace/drv/bus/usb/ohci/ohci.c (modified) (2 diffs)

uspace/drv/bus/usb/ohci/ohci.c

@@ -140 +140 @@
 int device_setup_ohci(ddf_dev_t *device)
 {
-        assert(device);
-
-        ohci_t *instance = malloc(sizeof(ohci_t));
+        if (device == NULL)
+                return EBADMEM;
+
+        ohci_t *instance = ddf_dev_data_alloc(device,sizeof(ohci_t));
         if (instance == NULL) {
                 usb_log_error("Failed to allocate OHCI driver.\n");
                 return ENOMEM;
         }
-        instance->rh_fun = NULL;
-        instance->hc_fun = NULL;
 
 #define CHECK_RET_DEST_FREE_RETURN(ret, message...) \
 if (ret != EOK) { \
         if (instance->hc_fun) { \
+                instance->hc_fun->driver_data = NULL; \
                 ddf_fun_destroy(instance->hc_fun); \
         } \
         if (instance->rh_fun) { \
+                instance->rh_fun->driver_data = NULL; \
                 ddf_fun_destroy(instance->rh_fun); \
         } \
-        free(instance); \
         usb_log_error(message); \
         return ret; \
@@ -219 +219 @@
             "Failed to init ohci_hcd: %s.\n", str_error(ret));
 
-        device->driver_data = instance;
-
 #define CHECK_RET_FINI_RETURN(ret, message...) \
 if (ret != EOK) { \