Changeset 9efad54 in mainline for uspace/lib/usbdev/include/usb/dev/pipes.h

Timestamp:

2018-01-06T21:15:48Z (6 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

56257ba

Parents:

c901632

Message:

usb: move endpoint descriptor parsing to HC

This better separates responsibilities. Now the device driver does not
care about the contents of an endpoint descriptor, and HC can parse the
values according to device's actual speed.

Currently, it is device driver's responsibility to fetch endpoint
descriptors, map them and register pipes - sending the endpoint
descriptor back to HC. HC then parses it, and fills the pipe
description, which then sends back to device driver. We shall probably
fetch the endpoint descriptor from inside the HC (also fixing the USB
spec violation of communication with EP0).

File:

• uspace/lib/usbdev/include/usb/dev/pipes.h (modified) (4 diffs)

uspace/lib/usbdev/include/usb/dev/pipes.h

@@ -37 +37 @@
 #include <usb/usb.h>
 #include <usb/descriptor.h>
-#include <usb_iface.h>
+#include <usbhc_iface.h>
 
 #include <stdbool.h>
@@ -44 +44 @@
 
 #define CTRL_PIPE_MIN_PACKET_SIZE 8
+
 /** Abstraction of a logical connection to USB device endpoint.
- * It encapsulates endpoint attributes (transfer type etc.).
+ * It contains some vital information about the pipe.
  * This endpoint must be bound with existing usb_device_connection_t
  * (i.e. the wire to send data over).
  */
 typedef struct {
-        /** Endpoint description */
-        usb_endpoint_desc_t desc;
+        /** Pipe description received from HC */
+        usb_pipe_desc_t desc;
+
         /** Whether to automatically reset halt on the endpoint.
          * Valid only for control endpoint zero.
@@ -100 +102 @@
 } usb_endpoint_mapping_t;
 
-int usb_pipe_initialize(usb_pipe_t *, usb_dev_session_t *, const usb_endpoint_desc_t *);
+int usb_pipe_initialize(usb_pipe_t *, usb_dev_session_t *, usb_transfer_type_t);
 int usb_pipe_initialize_default_control(usb_pipe_t *, usb_dev_session_t *);
 
@@ -106 +108 @@
     size_t, const uint8_t *, size_t, usb_dev_session_t *);
 
-int usb_pipe_register(usb_pipe_t *);
+int usb_pipe_register(usb_pipe_t *, const usb_standard_endpoint_descriptor_t *, const usb_superspeed_endpoint_companion_descriptor_t *);
 int usb_pipe_unregister(usb_pipe_t *);