Changeset b7fd2a0 in mainline for uspace/app/bdsh/compl.c

Timestamp:

2018-01-13T03:10:29Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/bdsh/compl.c (modified) (4 diffs)

uspace/app/bdsh/compl.c

@@ -40 +40 @@
 #include "tok.h"
 
-static int compl_init(wchar_t *text, size_t pos, size_t *cstart, void **state);
-static int compl_get_next(void *state, char **compl);
+static errno_t compl_init(wchar_t *text, size_t pos, size_t *cstart, void **state);
+static errno_t compl_get_next(void *state, char **compl);
 static void compl_fini(void *state);
 
@@ -87 +87 @@
  * Set up iterators in completion object, based on current token.
  */
-static int compl_init(wchar_t *text, size_t pos, size_t *cstart, void **state)
+static errno_t compl_init(wchar_t *text, size_t pos, size_t *cstart, void **state)
 {
         compl_t *cs = NULL;
@@ -93 +93 @@
         char *prefix = NULL;
         char *dirname = NULL;
-        int retval;
+        errno_t retval;
         
         token_t *tokens = calloc(WORD_MAX, sizeof(token_t));
@@ -288 +288 @@
 
 /** Get next match. */
-static int compl_get_next(void *state, char **compl)
+static errno_t compl_get_next(void *state, char **compl)
 {
         compl_t *cs = (compl_t *) state;