Changeset d9fae235 in mainline for uspace/srv/hid/kbd/generic/kbd.c

Timestamp:

2010-04-17T01:28:38Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9d6bfa5

Parents:

9256ad29

Message:

sysinfo overhaul

• cleanup (nicer data structures, use of SLAB allocator)
• add support for storing arbitrary binary data
• properly reimplement non-constant values (generated by functions)
• add support for non-constant subtrees (generated by functions)
• syscall ABI change, libc API change
• reflect changes in user code

libc: task_spawn() can now return error code

• reflect change in user code, print error strings after failed task_spawn()

uspace cleanup

• more use of string and other constants
• more use of str_error()
• unify error reporting in init

File:

• uspace/srv/hid/kbd/generic/kbd.c (modified) (3 diffs)

uspace/srv/hid/kbd/generic/kbd.c

@@ -212 +212 @@
 int main(int argc, char **argv)
 {
-        printf(NAME ": HelenOS Keyboard service\n");
-        
-        if (sysinfo_value("kbd.cir.fhc") == 1)
+        printf("%s: HelenOS Keyboard service\n", NAME);
+        
+        sysarg_t fhc;
+        sysarg_t obio;
+        
+        if ((sysinfo_get_value("kbd.cir.fhc", &fhc) == EOK) && (fhc))
                 cir_service = SERVICE_FHC;
-        else if (sysinfo_value("kbd.cir.obio") == 1)
+        else if ((sysinfo_get_value("kbd.cir.obio", &obio) == EOK) && (obio))
                 cir_service = SERVICE_OBIO;
         
@@ -240 +243 @@
         int rc = devmap_driver_register(NAME, client_connection);
         if (rc < 0) {
-                printf(NAME ": Unable to register driver (%d)\n", rc);
+                printf("%s: Unable to register driver (%d)\n", NAME, rc);
                 return -1;
         }
@@ -249 +252 @@
         dev_handle_t dev_handle;
         if (devmap_device_register(kbd, &dev_handle) != EOK) {
-                printf(NAME ": Unable to register device %s\n", kbd);
+                printf("%s: Unable to register device %s\n", NAME, kbd);
                 return -1;
         }