Changeset ed5367b in mainline for uspace/srv/sysman/job.c

Timestamp:

2019-08-07T10:01:13Z (5 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

a097c50

Parents:

68ae40a

git-author:

Michal Koutný <xm.koutny+hos@…> (2015-11-05 01:52:07)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2019-08-07 10:01:13)

Message:

sysman: Implement stopping units

Currently fails service monitoring because of taskman flawed event flags.
However, job closure works well.

File:

• uspace/srv/sysman/job.c (modified) (2 diffs)

uspace/srv/sysman/job.c

@@ -199 +199 @@
 
         int rc;
+        // TODO put here similar evaluation as in job_check
+        //      goal is to have job_run "idempotent"
         switch (job->target_state) {
         case STATE_STARTED:
-                // TODO put here same evaluation as in job_check
-                //      goal is to have job_run "idempotent"
                 if (u->state == job->target_state) {
                         rc = EOK;
@@ -209 +209 @@
                 }
                 break;
+        case STATE_STOPPED:
+                if (u->state == job->target_state) {
+                        rc = EOK;
+                } else {
+                        rc = unit_stop(u);
+                }
+                break;
         default:
-                // TODO implement other states
+                // TODO implement other states?
                 assert(false);
         }