Changeset ed5367b in mainline for uspace/srv/sysman/units/unit_mnt.c

Timestamp:

2019-08-07T10:01:13Z (5 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

a097c50

Parents:

68ae40a

git-author:

Michal Koutný <xm.koutny+hos@…> (2015-11-05 01:52:07)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2019-08-07 10:01:13)

Message:

sysman: Implement stopping units

Currently fails service monitoring because of taskman flawed event flags.
However, job closure works well.

File:

• uspace/srv/sysman/units/unit_mnt.c (modified) (1 diff)

uspace/srv/sysman/units/unit_mnt.c

@@ -229 +229 @@
 }
 
+static int unit_mnt_stop(unit_t *unit)
+{
+        unit_mnt_t *u_mnt = CAST_MNT(unit);
+        assert(u_mnt);
+        /* autostart implies blocking */
+        assert(!u_mnt->autostart || u_mnt->blocking);
+
+        
+        // TODO think about unit's lifecycle (is STOPPED only acceptable?)
+        // note: we should never hit STATE_STARTING, since it'd mean there are
+        //       two jobs running at once (unless job cancellation is implemented)
+        assert(unit->state == STATE_STARTED);
+
+        /*
+         * We don't expect unmount to be blocking, since if some files are
+         * being used, it'd return EBUSY immediately. That's why we call
+         * unmount synchronously in the event loop fibril.
+         */
+        int rc = unmount(u_mnt->mountpoint);
+
+        if (rc == EOK) {
+                unit->state = STATE_STOPPED;
+                return EOK;
+        } else if (rc == EBUSY) {
+                assert(unit->state == STATE_STARTED);
+                return EBUSY;
+        } else {
+                /*
+                 * Mount may be still usable, but be conservative and mark unit
+                 * as failed.
+                 */
+                unit->state = STATE_FAILED;
+                return rc;
+        }
+}
+
 static void unit_mnt_exposee_created(unit_t *unit)
 {